Add outstanding-request metrics per connected host #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschildmeijer
approved these changes
Jul 10, 2020
spkrka
force-pushed
the
krka/outstanding-per-host
branch
2 times, most recently
from
03bdf79 to
9d522d6
Compare
spkrka
force-pushed
the
krka/outstanding-per-host
branch
from
9d522d6 to
329992a
Compare
|
@spkrka SemanticFolsomMetricsTest::testRegisterOutstandingRequestsGauge is failing with this change. |
|
@spkrka did you have a chance to review my suggested fix? |
|
No, I am still not sure if this change even makes sense on a high level. |
|
@spkrka the motivation is to have metrics that will allow identifying misbehaving memcached nodes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.