Add support for more generic resolver #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protocol7
reviewed
Feb 12, 2019
| */ | ||
| public MemcacheClientBuilder<V> withSrvResolver(final DnsSrvResolver srvResolver) { | ||
| this.srvResolver = checkNotNull(srvResolver, "srvResolver"); |
There was a problem hiding this comment.
I screwed with this one, but this change is no longer needed
protocol7
reviewed
Feb 12, 2019
| client = clients.get(0); | ||
| } | ||
| } | ||
| final SrvKetamaClient client = |
There was a problem hiding this comment.
I guess this should not be named SrvKetamaClient now
protocol7
reviewed
Feb 12, 2019
| new SrvKetamaClient( | ||
| resolver, | ||
| DEFAULT_SCHEDULED_EXECUTOR.get(), | ||
| dnsRefreshPeriod, |
There was a problem hiding this comment.
This should also be renamed
protocol7
reviewed
Feb 12, 2019
| import com.spotify.folsom.ConnectionChangeListener; | ||
| import com.spotify.folsom.ObservableClient; | ||
| import com.spotify.folsom.RawMemcacheClient; | ||
| import com.spotify.folsom.*; |
There was a problem hiding this comment.
Do we want to use wildcard imports?
protocol7
reviewed
Feb 12, 2019
| for (LookupResult lookupResult : lookupResults) { | ||
| hosts.add(HostAndPort.fromParts(lookupResult.host(), lookupResult.port())); | ||
| ttl = Math.min(ttl, lookupResult.ttl()); | ||
| List<ResolveResult> resolveResults = resolver.resolve(); |
protocol7
reviewed
Feb 12, 2019
| hosts.add(HostAndPort.fromParts(lookupResult.host(), lookupResult.port())); | ||
| ttl = Math.min(ttl, lookupResult.ttl()); | ||
| List<ResolveResult> resolveResults = resolver.resolve(); | ||
| List<HostAndPort> hosts = Lists.newArrayListWithCapacity(resolveResults.size()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.