Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run swiftlint with strict flag #93

Merged
merged 1 commit into from
Apr 16, 2024
Merged

ci: run swiftlint with strict flag #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
- name: GitHub Action for SwiftLint
uses: norio-nomura/[email protected]
with:
args: --config .swiftlint.yml
args: --strict --config .swiftlint.yml
123 changes: 0 additions & 123 deletions .swiftpm/xcode/xcshareddata/xcschemes/Confidence-Package.xcscheme
View file
Open in desktop

This file was deleted.

66 changes: 0 additions & 66 deletions .swiftpm/xcode/xcshareddata/xcschemes/Confidence.xcscheme
View file
Open in desktop

This file was deleted.

92 changes: 0 additions & 92 deletions .swiftpm/xcode/xcshareddata/xcschemes/ConfidenceProvider.xcscheme
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions ConfidenceDemoApp/ConfidenceDemoAppTests/ConfidenceDemoTests.swift
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions ConfidenceDemoApp/ConfidenceDemoAppUITests/ConfidenceDemoUITests.swift
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions ConfidenceDemoApp/ConfidenceDemoAppUITests/ConfidenceDemoUITestsLaunchTests.swift
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions Sources/Common/Backport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ import Foundation
extension URL {
public struct Backport {
var base: URL

init(base: URL) {
self.base = base
}
}

public var backport: Backport {
Expand Down
1 change: 1 addition & 0 deletions Tests/ConfidenceProviderTests/ConfidenceFeatureProviderTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,3 +976,4 @@ final class DispatchQueueFakeSlow: DispatchQueueType {
}
}
}
// swiftlint:enable type_body_length
6 changes: 4 additions & 2 deletions Tests/ConfidenceProviderTests/EventUploaderMock.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ final class EventStorageMock: EventStorage {
}

func eventsFrom(id: String) throws -> [ConfidenceEvent] {
// swiftlint:disable:next force_unwrapping
return batches[id]!
guard let events = batches[id] else {
fatalError("id \(id) not found in batches")
}
return events
}

func remove(id: String) throws {
Expand Down
Loading
Loading