feat: Add awaitReconciliation #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
commented
Dec 5, 2024
Comment on lines
+345
to
+349
| Task { | ||
| await confidence.putContext(context: ["hello": .init(string: "world")]) | ||
| } | ||
| try await Task.sleep(nanoseconds: 100 * 1000) // 100 ms wait | ||
| await confidence.awaitReconciliation() |
There was a problem hiding this comment.
It's impossible to know if a putContext from another thread (Task) has been started or not (although it's always possible to know when it's done, via await putContext): even for a real application, the awaitReconciliation() could always be called "too soon" with respect to putContexts being started. In fact, I couldn't come up with a programmatic way to test this that doesn't include a sleep
There was a problem hiding this comment.
In other words, this function would be more useful if putContext wasn't awaitable. I am now unsure if having both await putContext and await awaitReconciliation makes sense
fabriziodemaria
force-pushed
the
api-adjustments
branch
23 times, most recently
from
f88f8d9 to
a4e3dd1
Compare
fabriziodemaria
force-pushed
the
api-adjustments
branch
2 times, most recently
from
8e6294f to
76410f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.