refactor!: Context APIs changes and documentation/onboarding #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
commented
Nov 28, 2024
fabriziodemaria
force-pushed
the
api-adjustments
branch
19 times, most recently
from
6e17a84 to
e4b588a
Compare
nicklasl
reviewed
Dec 3, 2024
nicklasl
reviewed
Dec 3, 2024
nicklasl
reviewed
Dec 3, 2024
fabriziodemaria
force-pushed
the
api-adjustments
branch
3 times, most recently
from
ef29aa2 to
7d808f3
Compare
fabriziodemaria
force-pushed
the
api-adjustments
branch
2 times, most recently
from
93211b7 to
fff6bd6
Compare
fabriziodemaria
force-pushed
the
api-adjustments
branch
7 times, most recently
from
0a9657e to
77f68a5
Compare
fabriziodemaria
force-pushed
the
api-adjustments
branch
2 times, most recently
from
2b988a8 to
f88f8d9
Compare
fabriziodemaria
force-pushed
the
api-adjustments
branch
from
f88f8d9 to
a4e3dd1
Compare
nicklasl
reviewed
Dec 10, 2024
Sources/Confidence/Confidence.swift
Outdated
Comment on lines
27
to
31
| didSet { | ||
| if let oldTask = oldValue { | ||
| oldTask.cancel() | ||
| } | ||
| } |
fabriziodemaria
force-pushed
the
api-adjustments
branch
5 times, most recently
from
a7ab0f3 to
d268518
Compare
nicklasl
reviewed
Dec 10, 2024
| /** | ||
| Ensures all the already-started context changes prior to this function have been reconciliated | ||
| */ | ||
| public func awaitReconciliation() async { |
There was a problem hiding this comment.
I would suggest awaitReady() instead...
There was a problem hiding this comment.
I think we should keep the same name used in Kotlin, i.e. awaitReconciliation
I'd be happy to create a pair of "renaming PRs" for both repos after this though, if we want to reach proper alignment (this would make sense especially now that the APIs between platforms are much more similar!)
fabriziodemaria
force-pushed
the
api-adjustments
branch
from
d268518 to
dedd011
Compare
fabriziodemaria
force-pushed
the
api-adjustments
branch
from
dedd011 to
0c38b46
Compare
nicklasl
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes:
putContextAndWaitaddedputContextcalls are executed in a serial fashion, and override existing calls for performanceputContexttriggersfetchAndActivatedirectly, and not as a side-effectcontextChanges()observable APIFixes and improvements:
Docs and onboarding: