refactor!: getEvaluation doesnt throw #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
requested review from
mfranberg,
vahidlazio,
nicklasl and
nickybondarenko
as code owners
nicklasl
previously approved these changes
Jul 10, 2024
nicklasl
force-pushed
the
eval-no-throw
branch
2 times, most recently
from
11375fb to
0a4d2b7
Compare
nicklasl
approved these changes
Jul 10, 2024
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not consistent if some errors are returned via
errorCodeanderrorMessagefields and other errors (i.e. flagNotFound) are handled via throwing.This is also the behaviour in OpenFeature.
toProviderEvaluation()