Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Basic E2E test for events upload #155

Merged
merged 5 commits into from
Jul 5, 2024
Merged

test: Basic E2E test for events upload #155

merged 5 commits into from
Jul 5, 2024

Conversation

fabriziodemaria
Copy link
Member

@fabriziodemaria fabriziodemaria commented Jul 4, 2024 •
edited
Loading

We could extend this setup to be more assertive about what has been actually sent and acked by backend, perhaps in future PRs

This approach might have the added benefit of keeping the logging messages also consistent and somewhat tested

nicklasl
nicklasl previously approved these changes Jul 5, 2024
View reviewed changes
nicklasl
nicklasl approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@nicklasl nicklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I would argue that from a user perspective it would also be nice to get debuglogger to tell you (on warning level perhaps?) if any events were not accepted by backend. We can take that in a separate PR however.

@fabriziodemaria fabriziodemaria merged commit 2e65c47 into main Jul 5, 2024
6 checks passed
@fabriziodemaria fabriziodemaria deleted the event-e2e-test branch July 5, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklasl nicklasl nicklasl approved these changes

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@vahidlazio vahidlazio Awaiting requested review from vahidlazio vahidlazio is a code owner

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko nickybondarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabriziodemaria @nicklasl