Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Differentiate OF non-OF in metadata #138

Closed
wants to merge 1 commit into from
Closed

feat: Differentiate OF non-OF in metadata #138

wants to merge 1 commit into from

Conversation

fabriziodemaria
Copy link
Member

@fabriziodemaria fabriziodemaria commented Jun 7, 2024 •
edited
Loading

  • This differentiation is not needed for general events, as their are (currently) only sent via CONFIDENCE.
  • This works for resolve calls, but not for apply events: the latter are still hardcoded to using "CONFIDENCE" as SDK ID.

@fabriziodemaria fabriziodemaria mentioned this pull request Jun 17, 2024
Closed
@fabriziodemaria fabriziodemaria marked this pull request as draft June 17, 2024 14:46
@fabriziodemaria fabriziodemaria mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@vahidlazio vahidlazio Awaiting requested review from vahidlazio vahidlazio is a code owner

@nicklasl nicklasl Awaiting requested review from nicklasl nicklasl is a code owner

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko nickybondarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fabriziodemaria