feat: add functionality to manual flush events #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
requested review from
fabriziodemaria,
mfranberg,
vahidlazio and
nickybondarenko
as code owners
| @@ -106,6 +109,10 @@ final class EventSenderEngineImpl: EventSenderEngine { | |||
| ) | |||
| } | |||
|
|
|||
| func flush() { | |||
| writeReqChannel.send(manualFlushEvent) | |||
There was a problem hiding this comment.
Could this be an alternative?
self.uploadReqChannel.send(EventSenderEngineImpl.sendSignalName)
self.flushPolicies.forEach { policy in policy.reset() }
So we don't need to treat the manual flush as a policy
There was a problem hiding this comment.
What I wanted to achieve with treating the flush as an event is that I want to allow all events in the write channel to be written and added to the flushed batch.
There was a problem hiding this comment.
I updated the PR description with some explanation about this.
There was a problem hiding this comment.
I see, good thinking there 👍
fabriziodemaria
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow for the user to manually trigger an upload to the backend services for all events emitted up to that point.
The approach used in this PR is to treat a call to the
flush()method as a special event emitted, which will mean that the events in the "write channel" will be guaranteed to have been written to disk (and thus applicable to be part of the "batch" to upload) before the actual flush happens.