-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Manage Events - track app lifecycle events #118
Conversation
… for int, fix some more tests
…t value for int, fix some more tests
…ear for demo app events
f3552aa
to
43ea3aa
Compare
… disappear for demo app events
d2c749f
to
e939392
Compare
11abf34
to
f05698e
Compare
488b9bd
to
2d4ba9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need at least some basic unit tests before merging
case UIApplication.didFinishLaunchingNotification: | ||
track(eventName: "app-launched") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am having issues getting this event emitted properly (with the is_foreground context), due to the order of function calls and notifications
0628956
to
f33d00d
Compare
Notes from manual testing:
|
67dc9f8
to
4ba7df7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual testing from Demo app seem to work correctly now. Approved!
No description provided.