Change time-related arg labels

spotify · Apr 5, 2024 · cf1a7b0 · cf1a7b0
1 parent 4fc0e97
commit cf1a7b0
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 7 deletions.
diff --git a/Sources/Confidence/ConfidenceValue.swift b/Sources/Confidence/ConfidenceValue.swift
@@ -52,12 +52,12 @@ public class ConfidenceValue: Equatable, Encodable {
     }
 
 
-    public init(dateComponentList: [DateComponents]) {
-        self.value = .list(dateComponentList.map { .date($0) })
+    public init(dateList: [DateComponents]) {
+        self.value = .list(dateList.map { .date($0) })
     }
 
-    public init(dateList: [Date]) {
-        self.value = .list(dateList.map { .timestamp($0) })
+    public init(timestampList: [Date]) {
+        self.value = .list(timestampList.map { .timestamp($0) })
     }
 
     public init(structure: [String: ConfidenceValue]) {

diff --git a/Tests/ConfidenceTests/ConfidenceValueTests.swift b/Tests/ConfidenceTests/ConfidenceValueTests.swift
@@ -41,9 +41,28 @@ final class ConfidenceConfidenceValueTests: XCTestCase {
         XCTAssertEqual(value.asDateComponents(), dateComponents)
     }
 
-    func testListShouldConvertToList() {
-        let value = ConfidenceValue(integerList: [3, 4])
-        XCTAssertEqual(value.asList(), [ConfidenceValue(integer: 3), ConfidenceValue(integer: 4)])
+    func testListShouldConvertToList() throws {
+        let formatter = DateFormatter()
+        formatter.dateFormat = "yyyy-MM-dd HH:mm:ss"
+        formatter.timeZone = TimeZone(abbreviation: "UTC")
+        let date1 = try XCTUnwrap(formatter.date(from: "2022-01-01 12:00:00"))
+        let dateComponents1 = DateComponents(year: 2024, month: 4, day: 3)
+        let date2 = try XCTUnwrap(formatter.date(from: "2022-01-02 00:00:00"))
+        let dateComponents2 = DateComponents(year: 2024, month: 4, day: 2)
+
+        let boolListValue = ConfidenceValue(boolList: [true, false])
+        let integerListValue = ConfidenceValue(integerList: [3, 4])
+        let doubleListValue = ConfidenceValue(doubleList: [3.14, 4.0])
+        let stringListValue = ConfidenceValue(stringList: ["val1", "val2"])
+        let timestampListValue = ConfidenceValue(timestampList: [date1, date2])
+        let dateListValue = ConfidenceValue(dateList: [dateComponents1, dateComponents2])
+
+        XCTAssertEqual(boolListValue.asList(), [ConfidenceValue(boolean: true), ConfidenceValue(boolean: false)])
+        XCTAssertEqual(integerListValue.asList(), [ConfidenceValue(integer: 3), ConfidenceValue(integer: 4)])
+        XCTAssertEqual(doubleListValue.asList(), [ConfidenceValue(double: 3.14), ConfidenceValue(double: 4.0)])
+        XCTAssertEqual(stringListValue.asList(), [ConfidenceValue(string: "val1"), ConfidenceValue(string: "val2")])
+        XCTAssertEqual(timestampListValue.asList(), [ConfidenceValue(timestamp: date1), ConfidenceValue(timestamp: date2)])
+        XCTAssertEqual(dateListValue.asList(), [ConfidenceValue(date: dateComponents1), ConfidenceValue(date: dateComponents2)])
     }
 
     func testStructShouldConvertToStruct() {