ci: run swiftlint with strict flag (#93)

spotify · Apr 16, 2024 · 8f253ce · 8f253ce
1 parent b5ba3e0
commit 8f253ce
Show file tree

Hide file tree

Showing 12 changed files with 9 additions and 364 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -29,4 +29,4 @@ jobs:
     - name: GitHub Action for SwiftLint
       uses: norio-nomura/[email protected]
       with:
-        args: --config .swiftlint.yml
+        args: --strict --config .swiftlint.yml
diff --git a/.swiftpm/xcode/xcshareddata/xcschemes/Confidence-Package.xcscheme b/.swiftpm/xcode/xcshareddata/xcschemes/Confidence-Package.xcscheme
diff --git a/.swiftpm/xcode/xcshareddata/xcschemes/Confidence.xcscheme b/.swiftpm/xcode/xcshareddata/xcschemes/Confidence.xcscheme
diff --git a/.swiftpm/xcode/xcshareddata/xcschemes/ConfidenceProvider.xcscheme b/.swiftpm/xcode/xcshareddata/xcschemes/ConfidenceProvider.xcscheme
diff --git a/ConfidenceDemoApp/ConfidenceDemoAppTests/ConfidenceDemoTests.swift b/ConfidenceDemoApp/ConfidenceDemoAppTests/ConfidenceDemoTests.swift
diff --git a/ConfidenceDemoApp/ConfidenceDemoAppUITests/ConfidenceDemoUITests.swift b/ConfidenceDemoApp/ConfidenceDemoAppUITests/ConfidenceDemoUITests.swift
diff --git a/ConfidenceDemoApp/ConfidenceDemoAppUITests/ConfidenceDemoUITestsLaunchTests.swift b/ConfidenceDemoApp/ConfidenceDemoAppUITests/ConfidenceDemoUITestsLaunchTests.swift
diff --git a/Sources/Common/Backport.swift b/Sources/Common/Backport.swift
@@ -3,10 +3,6 @@ import Foundation
 extension URL {
     public struct Backport {
         var base: URL
-
-        init(base: URL) {
-            self.base = base
-        }
     }
 
     public var backport: Backport {

diff --git a/Tests/ConfidenceProviderTests/ConfidenceFeatureProviderTest.swift b/Tests/ConfidenceProviderTests/ConfidenceFeatureProviderTest.swift
@@ -976,3 +976,4 @@ final class DispatchQueueFakeSlow: DispatchQueueType {
         }
     }
 }
+// swiftlint:enable type_body_length
diff --git a/Tests/ConfidenceProviderTests/EventUploaderMock.swift b/Tests/ConfidenceProviderTests/EventUploaderMock.swift
@@ -34,8 +34,10 @@ final class EventStorageMock: EventStorage {
     }
 
     func eventsFrom(id: String) throws -> [ConfidenceEvent] {
-        // swiftlint:disable:next force_unwrapping
-        return batches[id]!
+        guard let events = batches[id] else {
+            fatalError("id \(id) not found in batches")
+        }
+        return events
     }
 
     func remove(id: String) throws {
-Original file line number
+Diff line change
@@ Expand Up / @@ -976,3 +976,4 @@ final class DispatchQueueFakeSlow: DispatchQueueType { @@
             }
         }
     }
+    // swiftlint:enable type_body_length