hash only exists for confidence struct

spotify · Apr 17, 2024 · 65da6ea · 65da6ea
1 parent d6e45c0
commit 65da6ea
Show file tree

Hide file tree

Showing 5 changed files with 50 additions and 103 deletions.
diff --git a/Sources/ConfidenceProvider/ConfidenceFeatureProvider.swift b/Sources/ConfidenceProvider/ConfidenceFeatureProvider.swift
@@ -129,7 +129,11 @@ public class ConfidenceFeatureProvider: FeatureProvider {
         oldContext: OpenFeature.EvaluationContext?,
         newContext: OpenFeature.EvaluationContext
     ) {
-        guard oldContext?.hash() != newContext.hash() else {
+        var oldConfidenceContext: ConfidenceStruct = [:]
+        if let context = oldContext {
+            oldConfidenceContext = ConfidenceTypeMapper.from(ctx: context)
+        }
+        guard oldConfidenceContext.hash() != ConfidenceTypeMapper.from(ctx: newContext).hash() else {
             return
         }
 

diff --git a/Sources/ConfidenceProvider/Utils/EvaluationContextHash.swift b/Sources/ConfidenceProvider/Utils/EvaluationContextHash.swift
diff --git a/Tests/ConfidenceProviderTests/EvaluationContextHashTest.swift b/Tests/ConfidenceProviderTests/EvaluationContextHashTest.swift
diff --git a/Tests/ConfidenceProviderTests/Helpers/StorageMock.swift b/Tests/ConfidenceProviderTests/Helpers/StorageMock.swift
@@ -28,7 +28,7 @@ class StorageMock: Storage {
             if data.isEmpty {
                 return defaultValue
             }
-            return try JSONDecoder().decode(T.self, from: data.data)
+            return try JSONDecoder().decode(T.self, from: try XCTUnwrap(data.data(using: .utf8)))
         }
     }
 

diff --git a/Tests/ConfidenceTests/ConfidenceValueHashTest.swift b/Tests/ConfidenceTests/ConfidenceValueHashTest.swift
@@ -0,0 +1,44 @@
+import XCTest
+
+@testable import Confidence
+
+final class MutableContextTests: XCTestCase {
+    func testHashRespectsTargetingKey() throws {
+        let ctx1: ConfidenceStruct =
+        ["targetingKey": ConfidenceValue(string: "user1"), "structure": ConfidenceValue(structure: [:])]
+        let ctx2: ConfidenceStruct =
+        ["targetingKey": ConfidenceValue(string: "user2"), "structure": ConfidenceValue(structure: [:])]
+
+        XCTAssertNotEqual(ctx1.hash(), ctx2.hash())
+    }
+
+    func testHashRespectsStructure() throws {
+        let ctx1: ConfidenceStruct =
+        [
+            "targetingKey": ConfidenceValue(string: "user1"),
+            "structure": ConfidenceValue(structure: ["integer": ConfidenceValue(integer: 3)])
+        ]
+        let ctx2: ConfidenceStruct =
+        [
+            "targetingKey": ConfidenceValue(string: "user2"),
+            "structure": ConfidenceValue(structure: ["integer": ConfidenceValue(integer: 4)])
+        ]
+
+        XCTAssertNotEqual(ctx1.hash(), ctx2.hash())
+    }
+
+    func testHashIsEqualForEqualContext() throws {
+        let ctx1: ConfidenceStruct =
+        [
+            "targetingKey": ConfidenceValue(string: "user1"),
+            "structure": ConfidenceValue(structure: ["integer": ConfidenceValue(integer: 3)])
+        ]
+        let ctx2: ConfidenceStruct =
+        [
+            "targetingKey": ConfidenceValue(string: "user2"),
+            "structure": ConfidenceValue(structure: ["integer": ConfidenceValue(integer: 3)])
+        ]
+
+        XCTAssertNotEqual(ctx1.hash(), ctx2.hash())
+    }
+}