fix: Remove extra slash in URL (#74)

spotify · Jan 31, 2024 · 1f33e21 · 1f33e21
1 parent b91bcdc
commit 1f33e21
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Sources/ConfidenceProvider/Http/NetworkClient.swift b/Sources/ConfidenceProvider/Http/NetworkClient.swift
@@ -102,7 +102,7 @@ struct RequestResult {
 
 extension NetworkClient {
     private func constructURL(base: String, path: String) -> URL? {
-        let normalisedBase = base.hasSuffix("/") ? base : "\(base)/"
+        let normalisedBase = base.hasSuffix("/") ? base : "\(base)"
         let normalisedPath = path.hasPrefix("/") ? String(path.dropFirst()) : path
 
         return URL(string: "\(normalisedBase)\(normalisedPath)")

diff --git a/Tests/ConfidenceProviderTests/Helpers/MockedConfidenceClientURLProtocol.swift b/Tests/ConfidenceProviderTests/Helpers/MockedConfidenceClientURLProtocol.swift
@@ -43,7 +43,7 @@ class MockedConfidenceClientURLProtocol: URLProtocol {
         }
 
         switch path {
-        case _ where path.hasSuffix(":resolve"):
+        case _ where path.hasSuffix("/flags:resolve"):
             return resolve()
         default:
             client?.urlProtocol(self, didFailWithError: NSError(domain: "test", code: URLError.badURL.rawValue))