feat!: STALE returns last-seen value

spotify · Dec 2, 2024 · 1c5c9dc · 1c5c9dc
1 parent 5b3d62a
commit 1c5c9dc
Showing 1 changed file with 6 additions and 11 deletions.
diff --git a/Sources/Confidence/FlagEvaluation.swift b/Sources/Confidence/FlagEvaluation.swift
@@ -32,15 +32,6 @@ extension FlagResolution {
         flagApplier: FlagApplier? = nil,
         debugLogger: DebugLogger? = nil
     ) -> Evaluation<T> {
-        if self.context != context {
-            return Evaluation(
-                value: defaultValue,
-                variant: nil,
-                reason: .stale,
-                errorCode: nil,
-                errorMessage: nil
-            )
-        }
         do {
             let parsedKey = try FlagPath.getPath(for: flagName)
             let resolvedFlag = self.flags.first { resolvedFlag in  resolvedFlag.flag == parsedKey.flag }
@@ -80,14 +71,18 @@ extension FlagResolution {
             let typedValue: T? = getTyped(value: parsedValue)
 
             if resolvedFlag.resolveReason == .match {
+                var resolveReason: ResolveReason = .match
+                if self.context != context {
+                    resolveReason = .stale
+                }
                 if let typedValue = typedValue {
                     Task {
                         await flagApplier?.apply(flagName: parsedKey.flag, resolveToken: self.resolveToken)
                     }
                     return Evaluation(
                         value: typedValue,
                         variant: resolvedFlag.variant,
-                        reason: resolvedFlag.resolveReason,
+                        reason: resolveReason,
                         errorCode: nil,
                         errorMessage: nil
                     )
@@ -100,7 +95,7 @@ extension FlagResolution {
                         return Evaluation(
                             value: defaultValue,
                             variant: resolvedFlag.variant,
-                            reason: resolvedFlag.resolveReason,
+                            reason: resolveReason,
                             errorCode: nil,
                             errorMessage: nil
                         )