Fixing issue with 2024 pass completions not having right yardage #104
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes include enhancements to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant add_yardage
participant cfbd_pbp_data
User->>add_yardage: Process play data
add_yardage->>cfbd_pbp_data: Validate yardage and completions
cfbd_pbp_data-->>add_yardage: Return processed data
add_yardage-->>User: Display results
Tip New review modelWe have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- R/helper_pbp_add_yardage.R (1 hunks)
- tests/testthat/test-cfbd_pbp_data.R (1 hunks)
Additional comments not posted (4)
tests/testthat/test-cfbd_pbp_data.R (2)
1-20: LGTM!The test is well-structured, follows the AAA pattern, and verifies the expected behavior for handling play-by-play data for the 2024 season. The test name is descriptive and the assertion is clear.
22-40: LGTM!The test is well-structured, follows the AAA pattern, and verifies the expected behavior for handling play-by-play data for the 2023 season. The test name is descriptive and the assertion is clear.
R/helper_pbp_add_yardage.R (2)
89-90: LGTM!The code changes enhance the logic for determining the yardage gained from completed passes by adding a new condition to check for the presence of a yardage value in the play text. The regex pattern used is appropriate for matching the yardage value.
94-96: LGTM!The code changes introduce a new condition to handle cases where the yardage is recorded separately from the play text. By assigning the value of
yards_gainedtoyds_receivingwhen the play is a completed pass, the function's ability to handle scenarios where yardage information may not be included in the play text but is available in theyards_gainedfield is improved. This enhances the robustness of the data processing.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- tests/testthat/test-cfbd_pbp_data.R (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- tests/testthat/test-cfbd_pbp_data.R
Summary by CodeRabbit
New Features
Tests