chore(release): merge develop to main #327

mkolasinski-splunk · 2024-09-03T12:10:55Z

Test runs:

Changelog:

Extend Workflow Summary with results of tests - providing one glance
overview of tests results together with links to test reports
Workflow dispatch with custom-version input to enable TA maintenance
releases
List of OS for scripted input tests can now be defined as an input
Splunk builds are partitioned - this feature was restored as is being
utilised in specific TA scenarios
New input:execute-tests-on-push-to-release defaulting to false to
allow control over workflows execution on push event to release/*
branches
replace returntocorp/semgrep with Splunk reusable workflow
splunk/sast-scanning
remove cim-field-report from reusable workflow
Fix errors when uploading diags for failed jobs when encountering
duplicated names in markers run scenario
Fix argo logs s3 download path - now argo logs will be available to
review as a workflow artifact
scripted-inputs-tests execution is now not limited to main branch
only

Deps updates:

amannn/action-semantic-pull-request to v5.5.3
trufflesecurity/trufflehog to v3.81.10
addonfactory-test-matrix-action automatically updated to v2.1.7 (SC4S
update 3.28.1 -> 3.30.0)
k8s-manifests bump v3.0.3 -> v3.0.5 (ESCU tests and cim-field-report
removal)

Update image of unreleased splunk with python 3.9 to build https://cd.splunkdev.com/splcore/main/-/tree/f8b1a92a256b (Splunk 9.3) Tests: https://github.com/splunk/splunk-add-on-for-servicenow/actions/runs/9692653841/job/26746592496?pr=741 https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/9692491380/job/26746170582?pr=735 To be released as a bugfix.

List of OSs for scripted inputes tests can be provided as an input to reusable workflow. Tested: splunk/splunk-add-on-for-unix-and-linux#577

Add documentation regarding docker images used in reusable workflow with unreleased splunk.

This PR resumes partioned builds creation. Jira: https://splunk.atlassian.net/browse/ADDON-72517 Test run: https://github.com/splunk/splunk-add-on-for-mysql/actions/runs/9890730582 (the partial packages are contained in `package-deployment` artifact)

bump matrix-action to v2.0.2 which includes sc4s v3.28.0 tests: splunk/splunk-add-on-for-cisco-esa#440 Report before update (58 KO failures) https://github.com/splunk/splunk-add-on-for-cisco-esa/runs/27652534705 report after update (12 KO failrues) https://github.com/splunk/splunk-add-on-for-cisco-esa/runs/27656994881

### Background In certain scenarios, some clients prefer not to update to the latest version of the software but require critical bug fixes in their current version. This necessitates bypassing the automated versioning provided by semantic-release, allowing for a manually specified version to be released. ### Changes Introduced In this PR, I've introduced a dispatcher to the workflow, enabling users to specify a custom version when triggering a release. This enhancement provides greater flexibility, particularly for clients who need targeted updates without adopting the latest release. ### Key Implementations: * Custom-Version Dispatcher: Added a dispatcher that allows users to input a custom version number when initiating a release. This ensures that specific bug fixes can be released independently of the standard semantic-release process. * Release Workflow: Integrated the release process with softprops/action-gh-release@v2, ensuring a smooth and consistent release experience while accommodating the custom version specified by the user. ### Discussion Point: Tag Creation and Workflow Rerun: Currently, when a custom version is used and a package is released, the workflow is triggered again because a tag is created. This raises the question: Is it necessary to trigger the workflow with a tag, or should we consider an alternative approach to prevent redundant workflow executions? Feedback on this point would be appreciated. ### Test branch: [https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/10353886295](https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/10353886295) ### References Implementation docs: [https://docs.google.com/document/d/1Qenm338CyoeZHo3M_dbX5GJD1SDmlLhz1Jfpg7VWrPg/edit](https://docs.google.com/document/d/1Qenm338CyoeZHo3M_dbX5GJD1SDmlLhz1Jfpg7VWrPg/edit) GitHub Action: [softprops/action-gh-release@v2](https://github.com/softprops/action-gh-release)

This PR removes steps `Upload cim-field-report` from `run-knowledge-tests` and `Download cim-field-report` from `publish` stage. fixes: https://splunk.atlassian.net/browse/ADDON-73385

Test run: https://github.com/splunk/splunk-add-on-for-microsoft-sysmon/pull/322/checks

Adjusting workflow trigger on `develop` branch to revert unnecessary change in #309

Test run: splunk/splunk-add-on-for-google-cloud-platform#757

tests: https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/10619286231

Updated the build-test-release workflow to use [sast-scan](https://github.com/splunk/sast-scanning) owned by product security team instead of using custom implementation. Ref: https://splunk.atlassian.net/browse/ADDON-72309 Test workflow run: https://github.com/splunk/splunk-add-on-for-servicenow/actions/runs/10596615468 Tested on PR: splunk/splunk-add-on-for-servicenow#751 Workflow is not tested for the failure scenario because we need to have blocker findings by the semgrep in order to fail the workflow. Currently all rules are in monitor mode so any findings by the semgrep will be non-blocker resulting in semgrep stage to pass everytime. Discussion with the semgrep team: https://splunk.slack.com/archives/C011ELTV7FG/p1724923496371529

Updating README.md to be aligned with the latest changes (#309). --------- Co-authored-by: mkolasinski-splunk <[email protected]>

Added job summaries to relevant jobs to provide better accessibility. GA link : https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/10597121787

fix: ga summary report scripted input filename fix

test run: https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/10643905753

srv-rr-github-token · 2024-09-03T13:43:29Z

🎉 This PR is included in version 4.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

mkolasinski-splunk and others added 29 commits June 24, 2024 13:43

chore: backport changes from main (#292)

ce2cdea

chore: backport changes from main (#297) (#298)

2af4f65

fix: add input for scripted inputs os (#296)

72497e5

List of OSs for scripted inputes tests can be provided as an input to reusable workflow. Tested: splunk/splunk-add-on-for-unix-and-linux#577

docs: extend docker image documentation by unreleased splunk (#293)

a538fe3

Add documentation regarding docker images used in reusable workflow with unreleased splunk.

docs: document Splunk docker image with java

1544130

docs: document Splunk docker image with java (#304)

9cbf49f

Merge branch 'main' into develop

b49a9f0

feat: add publish for custom version

efb57ff

fix: remove cim-field-report (#310)

f135b1b

This PR removes steps `Upload cim-field-report` from `run-knowledge-tests` and `Download cim-field-report` from `publish` stage. fixes: https://splunk.atlassian.net/browse/ADDON-73385

feat: update appinpsect_cli_action to 2.8

806fb1c

feat: update appinpsect_cli_action to 2.8 (#318)

8652407

Test run: https://github.com/splunk/splunk-add-on-for-microsoft-sysmon/pull/322/checks

chore: adjust workflow trigger on develop (#317)

309101f

Adjusting workflow trigger on `develop` branch to revert unnecessary change in #309

chore: remove branch conditions from scripted-inputs-tests (#319)

171543f

fix: unique name for diag artifacts for marker runs (#322)

30fa54a

Test run: splunk/splunk-add-on-for-google-cloud-platform#757

deps: bump k8s-manifests version (#320)

fb4c2f8

fix: update path for argo logs pull from s3 (#321)

273675b

tests: https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/10619286231

docs: update setup-workflow description in README.md (#315)

2e92f1f

Updating README.md to be aligned with the latest changes (#309). --------- Co-authored-by: mkolasinski-splunk <[email protected]>

feat: adding job summaries (#312)

c35feae

Added job summaries to relevant jobs to provide better accessibility. GA link : https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/10597121787

fix: scripted inputs summary (#323)

ae3f3bd

fix: ga summary report scripted input filename fix

fix: modinput issues (#324)

5093156

test run: https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/10643905753

chore: fixing table for scripted input report (#326)

1551fcc

artemrys marked this pull request as ready for review September 3, 2024 13:37

artemrys requested a review from a team as a code owner September 3, 2024 13:37

artemrys approved these changes Sep 3, 2024

View reviewed changes

mkolasinski-splunk merged commit 85eb70c into main Sep 3, 2024
18 checks passed

github-actions bot locked and limited conversation to collaborators Sep 3, 2024

srv-rr-github-token added the released label Sep 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(release): merge develop to main #327

chore(release): merge develop to main #327

mkolasinski-splunk commented Sep 3, 2024

srv-rr-github-token commented Sep 3, 2024

chore(release): merge develop to main #327

chore(release): merge develop to main #327

Conversation

mkolasinski-splunk commented Sep 3, 2024

srv-rr-github-token commented Sep 3, 2024