-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add btool check #316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-dabro
previously approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please remember to change splunk/wfe-test-runner-action
versions to new release once it's ready
Test runs: - [ ] https://github.com/splunk/splunk-add-on-for-unix-and-linux/actions/runs/10632526511 - [ ] https://github.com/splunk/splunk-add-on-for-salesforce/actions/runs/10632622057 - [ ] https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/10632591109 - [ ] https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/10632560662 - [ ] https://github.com/splunk/splunk-add-on-for-jboss/actions/runs/10632609697 Changelog: - Extend Workflow Summary with results of tests - providing one glance overview of tests results together with links to test reports - Workflow dispatch with `custom-version` input to enable TA maintenance releases - List of OS for scripted input tests can now be defined as an input - Splunk builds are partitioned - this feature was restored as is being utilised in specific TA scenarios - New input:`execute-tests-on-push-to-release` defaulting to `false` to allow control over workflows execution on push event to `release/*` branches - replace `returntocorp/semgrep` with Splunk reusable workflow `splunk/sast-scanning` - remove cim-field-report from reusable workflow - Fix errors when uploading diags for failed jobs when encountering duplicated names in markers run scenario - Fix argo logs s3 download path - now argo logs will be available to review as a workflow artifact - scripted-inputs-tests execution is now not limited to `main` branch only Deps updates: - amannn/action-semantic-pull-request to v5.5.3 - trufflesecurity/trufflehog to v3.81.9 - addonfactory-test-matrix-action automatically updated to v2.1.7 (SC4S update 3.28.1 -> 3.30.0) - k8s-manifests bump v3.0.3 -> v3.0.5 (ESCU tests and cim-field-report removal) --------- Co-authored-by: Artem Rys <[email protected]> Co-authored-by: kdoroszko-splunk <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: kgwizdz-splunk <[email protected]> Co-authored-by: Adam Wownysz <[email protected]> Co-authored-by: dvarasani-crest <[email protected]> Co-authored-by: Marcin Bruzda <[email protected]> Co-authored-by: harshilgajera-crest <[email protected]>
Test runs: - [x] https://github.com/splunk/splunk-add-on-for-unix-and-linux/actions/runs/10632526511 - [x] https://github.com/splunk/splunk-add-on-for-salesforce/actions/runs/10632622057 - [x] https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/10632591109 - [x] https://github.com/splunk/splunk-add-on-for-google-cloud-platform/actions/runs/10632560662 - [x] https://github.com/splunk/splunk-add-on-for-jboss/actions/runs/10632609697 Changelog: - Extend Workflow Summary with results of tests - providing one glance overview of tests results together with links to test reports - Workflow dispatch with `custom-version` input to enable TA maintenance releases - List of OS for scripted input tests can now be defined as an input - Splunk builds are partitioned - this feature was restored as is being utilised in specific TA scenarios - New input:`execute-tests-on-push-to-release` defaulting to `false` to allow control over workflows execution on push event to `release/*` branches - replace `returntocorp/semgrep` with Splunk reusable workflow `splunk/sast-scanning` - remove cim-field-report from reusable workflow - Fix errors when uploading diags for failed jobs when encountering duplicated names in markers run scenario - Fix argo logs s3 download path - now argo logs will be available to review as a workflow artifact - scripted-inputs-tests execution is now not limited to `main` branch only Deps updates: - amannn/action-semantic-pull-request to v5.5.3 - trufflesecurity/trufflehog to v3.81.10 - addonfactory-test-matrix-action automatically updated to v2.1.7 (SC4S update 3.28.1 -> 3.30.0) - k8s-manifests bump v3.0.3 -> v3.0.5 (ESCU tests and cim-field-report removal)
This PR bumps `k8s-manifests-branch` version. It increases requests rate limit for GitHub api. Related PR splunk/ta-automation-k8s-manifests#103 Tested here: https://github.com/splunk/splunk-add-on-for-amazon-web-services/actions/runs/10697833642/job/29656542503
pawel-dabro
approved these changes
Sep 6, 2024
This PR bumps `k8s-manifests-branch` version. It fixes the below items, - Stopped the diag generation in case of passed tests - fixed cim-compliance-report generation Related PRs: (Stop diag generation) - splunk/ta-automation-app-of-apps#21 - splunk/ta-automation-k8s-manifests#104 - https://cd.splunkdev.com/workflow-engine/ta/ta-automation-cluster/-/merge_requests/63 (fix cim-compliance-report) - splunk/ta-automation-k8s-manifests#105 Test workflow run: https://github.com/splunk/splunk-add-on-for-mysql/actions/runs/10767934733/job/29856231470
pawel-dabro
previously approved these changes
Sep 18, 2024
This PR bumps the version of k8s-manifests-branch to fix the issue with the diag generation. related PR: splunk/ta-automation-k8s-manifests#106 test workflow run: - https://github.com/splunk/splunk-add-on-for-google-workspace/actions/runs/10631152841 - https://github.com/splunk/splunk-add-on-for-servicenow/actions/runs/10919108085
dvarasani-crest
force-pushed
the
feat/add-btool-check
branch
from
September 18, 2024 12:23
afc8ddf
to
1b07aab
Compare
mkolasinski-splunk
approved these changes
Sep 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added workflow
run btool check
to validate the configuration in the TA using btool checkRef: https://splunk.atlassian.net/browse/ADDON-70489
Test workflow runs: