chore(google): upgrade google api libraries to match client 2.4.1 #1208
Conversation
edgarulg
requested review from
jasonmcintosh,
link108,
christosarvanitis and
dbyron-sf
|
I created a snapshot version for this change and validated a few spinnaker services. Front50 is the service that will need changes to adapt tests to the new version of google-api-client. I will fix every autobump PR failure resulting of this changes in the Spinnaker services. |
| groovy : "4.0.15", | ||
| jsch : "0.1.54", | ||
| jschAgentProxy : "0.0.9", | ||
| // spring boot 2.7.18 specifies logback 1.2.12. Pin to 1.2.13 to resolve | ||
| // CVE-2023-6378 and CVE-2023-6481 until spring boot 3.1.7 which brings in | ||
| // 1.4.14. See https://logback.qos.ch/news.html#1.3.12. | ||
| logback : "1.2.13", | ||
| protobuf : "3.21.12", | ||
| protobuf : "3.25.2", |
There was a problem hiding this comment.
I suspect
kork/kork-proto/kork-proto.gradle
Line 15 in cf76e73
There was a problem hiding this comment.
To be fair, the protoc doesn't have to match the GCP sdk versions as I believe all 3 versions are ABI compatible. NOW protoc 3 vs. 4... 4 is "DANGER ZONE" due to some changes in protoc. BUT so far all the google api SDK's use protoc 3 based versions.
The best way to do this is to create a draft PR with the changes in other microservices before merging this PR. |
|
@dbyron-sf @jasonmcintosh I released a new version of this change in kork and I addressed all the autobump PRs with issues: I will build and deploy snapshot versions of clouddriver & front50 in my spinnaker instance. I need to verify appengine, GCE and GCS did not break with the upgrade |
Upgrade version of
google-api-clientto2.4.1and upgrade all com.google.apislibraries to match the same google-api-client.Context about libraries:
google-api-client: https://mvnrepository.com/artifact/com.google.api-client/google-api-client/2.4.1
google-api-services-compute: https://mvnrepository.com/artifact/com.google.apis/google-api-services-compute/beta-rev20240430-2.0.0
google-api-services-admin-directory: https://mvnrepository.com/artifact/com.google.apis/google-api-services-admin-directory/directory_v1-rev20240429-2.0.0
google-api-services-cloudbuild: https://mvnrepository.com/artifact/com.google.apis/google-api-services-cloudbuild/v1-rev20240427-2.0.0
google-api-services-iam: https://mvnrepository.com/artifact/com.google.apis/google-api-services-iam/v1-rev20240502-2.0.0
google-api-services-monitoring: https://mvnrepository.com/artifact/com.google.apis/google-api-services-monitoring/v3-rev20240427-2.0.0
google-api-services-storage: https://mvnrepository.com/artifact/com.google.apis/google-api-services-storage/v1-rev20240319-2.0.0
google-cloud-secretmanager: https://mvnrepository.com/artifact/com.google.cloud/google-cloud-secretmanager/2.37.0
google-cloud-libraries: https://mvnrepository.com/artifact/com.google.cloud/libraries-bom/26.34.0
Libraries moved from Clouddriver to kork:
google-api-services-appengine: https://mvnrepository.com/artifact/com.google.apis/google-api-services-appengine/v1-rev20240415-2.0.0
google-api-services-run(cloudrun): https://mvnrepository.com/artifact/com.google.apis/google-api-services-run/v1-rev20240426-2.0.0
All the libraries matches the google-api-client:2.4.1 and also the libraries provided by the client.
Related: spinnaker/spinnaker#6931