Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MTS and add T1w disc labels #30

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Fix MTS and add T1w disc labels #30

merged 5 commits into from
Feb 21, 2024

Conversation

sandrinebedard
Copy link
Member

Description

This PR adresses #25 . It fixes the MTS filenames to comply with BIDS.

It adds T1w manual disc labels too. (Sorry for adding this in the same branch )

@sandrinebedard sandrinebedard changed the title Fix MTS and add T2w disc labels Fix MTS and add T1w disc labels Jan 26, 2024
@mguaypaq
Copy link
Member

Sorry for the delay. But it looks like the image files for the manual disc labels are not uploaded to Amazon. Can you run the commands from Step 6 of the upload instructions?

Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the missing image, the PR looks good:

  • The json sidecars for the new labels look fine.
  • The MTS rename is OK.
  • All the RPI_r suffixes got removed.
  • bids-validator is happy.

The CI checks are failing because of an unrelated problem: the script is pinned to v2.3 of the spine-generic validation script, which fails to install because the dependency sklearn got renamed to scikit-learn. I'll make a new release v2.3.1 to fix this, and we can unpin the spine-generic validation script in a different PR.

@sandrinebedard
Copy link
Member Author

re failing because of an unrelated problem: the script is

oups my bad! shoul be there now!

@sandrinebedard
Copy link
Member Author

I got an error when running the following command for the disc labels:

(base) sebeda@joplin:~/datasets/data-single-subject$ git annex copy --to amazon
copy derivatives/labels/sub-chibaIngenia/anat/sub-chibaIngenia_T1w_labels-disc-manual.nii.gz (checking amazon...) (HttpExceptionRequest Request {
  host                 = "data-single-subject---spine-generic---neuropoly.s3.ca-central-1.amazonaws.com"
  port                 = 443
  secure               = True
  requestHeaders       = [("Date","Wed, 21 Feb 2024 19:29:21 GMT"),("Authorization","<REDACTED>"),("X-Amz-Content-Sha256","e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"),("X-Amz-Date","20240221T192921Z")]
  path                 = "/SHA256E-s86109--c3bbcd626b43663dbc500ecc65c54756abcbb93a6162a9ad76ecb4daaa2a0258.nii.gz"
  queryString          = ""
  method               = "HEAD"
  proxy                = Nothing
  rawBody              = False
  redirectCount        = 10
  responseTimeout      = ResponseTimeoutDefault
  requestVersion       = HTTP/1.1
}

 (StatusCodeException (Response {responseStatus = Status {statusCode = 403, statusMessage = "Forbidden"}, responseVersion = HTTP/1.1, responseHeaders = [("x-amz-request-id","ZG182H0X4PCDETR6"),("x-amz-id-2","0ZVheexX8/zXEqLDsunGdBC1Z8Bu7SvYONgoEVUDbjIM2bqJA9MDGV0sbFgBQjAUgifpc3EmwAI="),("Content-Type","application/xml"),("Date","Wed, 21 Feb 2024 19:29:21 GMT"),("Server","AmazonS3")], responseBody = (), responseCookieJar = CJ {expose = []}, responseClose' = ResponseClose}) "")) failed
copy derivatives/labels/sub-douglas/anat/sub-douglas_T1w_labels-disc-manual.nii.gz (checking amazon...) (HttpExceptionRequest Request {
  host                 = "data-single-subject---spine-generic---neuropoly.s3.ca-central-1.amazonaws.com"
  port                 = 443
  secure               = True
  requestHeaders       = [("Date","Wed, 21 Feb 2024 19:29:22 GMT"),("Authorization","<REDACTED>"),("X-Amz-Content-Sha256","e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"),("X-Amz-Date","20240221T192922Z")]
  path                 = "/SHA256E-s69995--2977e303bf5f589a9a0fb9f02ce1e6d4727ab35c0d68e24769cc5979d8229bb3.nii.gz"
  queryString          = ""
  method               = "HEAD"
  proxy                = Nothing
  rawBody              = False
  redirectCount        = 10
  responseTimeout      = ResponseTimeoutDefault
  requestVersion       = HTTP/1.1
}

@sandrinebedard
Copy link
Member Author

The discs should now be on amazon!

@mguaypaq mguaypaq merged commit 758b477 into master Feb 21, 2024
1 check passed
@mguaypaq mguaypaq deleted the sb/25-fix-mts-filename branch February 21, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants