-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MTS and add T1w disc labels #30
Conversation
Sorry for the delay. But it looks like the image files for the manual disc labels are not uploaded to Amazon. Can you run the commands from Step 6 of the upload instructions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the missing image, the PR looks good:
- The json sidecars for the new labels look fine.
- The MTS rename is OK.
- All the
RPI_r
suffixes got removed. - bids-validator is happy.
The CI checks are failing because of an unrelated problem: the script is pinned to v2.3 of the spine-generic validation script, which fails to install because the dependency sklearn
got renamed to scikit-learn
. I'll make a new release v2.3.1 to fix this, and we can unpin the spine-generic validation script in a different PR.
oups my bad! shoul be there now! |
I got an error when running the following command for the disc labels:
|
The discs should now be on amazon! |
Description
This PR adresses #25 . It fixes the MTS filenames to comply with BIDS.
It adds T1w manual disc labels too. (Sorry for adding this in the same branch )