Add options for sub-folder and for func sesssions #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanbanerjee
approved these changes
May 18, 2024
valosekj
reviewed
May 19, 2024
Comment on lines
+593
to
+594
| print(os.path.isfile(fname_label)) | ||
| print('fname_label', fname_label) |
There was a problem hiding this comment.
@rohanbanerjee, these two prints might be removed, right? I guess they were used for debugging.
There was a problem hiding this comment.
I agree, missed on removing them. On it.
valosekj
reviewed
May 19, 2024
| @@ -897,6 +1022,7 @@ def main(): | |||
| # a JSON file | |||
| update_json(fname_out, name_rater, json_metadata) | |||
| # Generate QC report | |||
| #generate_qc(fname, fname_out, task, fname_qc, subject, args.config, args.qc_lesion_plane, suffix_dict) | |||
There was a problem hiding this comment.
@rohanbanerjee, I believe that this line was commented on only for debugging the fmri case. In other cases, we want to generate QC. Thus, I believe a condition checking if contrast = 'func' should be added here.
valosekj
reviewed
May 19, 2024
| @@ -215,6 +215,12 @@ def get_parser(): | |||
| type=str, | |||
| default=None | |||
| ) | |||
| parser.add_argument( #TODO | |||
| '-add-subfolder', | |||
| help="Add a subfolder to find labels or segmentation to correct", | |||
There was a problem hiding this comment.
Example(s) should be added here
|
Thanks for the review @rohanbanerjee! However, I left a few comments which need to be adrrresed. |
rohanbanerjee
added a commit
that referenced
this pull request
May 28, 2024
This reverts commit 7242702.
valosekj
pushed a commit
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I add the option for the
funcsub-folder inutils.pyI also add the option for a
sub-folderin the path-img, but maybe we do not want that! A better solution for this is to get the image path not by recreating it.Related issues: #81