Cleanup unused vector (#667)

.github/workflows/publish.yml

@@ -28,7 +28,7 @@ jobs:
         uses: hendrikmuhs/ccache-action@v1
 
       - name: Setup Dependencies
-        run: sudo apt-get install ninja-build pipx uuid-dev
+        run: sudo apt-get install ninja-build pipx uuid-dev checksec jq
 
       - name: Cache LLVM
         id: cache-llvm
@@ -66,6 +66,10 @@ jobs:
           mv ./src/spice spice
           chmod +x spice
 
+      - name: Run Checksec
+        working-directory: bin
+        run: checksec --file=./spice --output=json | jq
+
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         with:

src-bootstrap/ast/ast-nodes.spice

@@ -45,7 +45,7 @@ p ASTNode.ctor(CodeLoc codeLoc) {
     assert false; // Please override at child level
 }*/
 
-public p ASTNode.addChild(ASTNode *child) {
+public p ASTNode.addChild(ASTNode* child) {
     this.children.pushBack(child);
     child.parent = this;
 }

src-bootstrap/global/global-resource-manager.spice

@@ -37,7 +37,6 @@ public type GlobalResourceManager struct : IGlobalResourceManager {
     public Vector<String> compileTimeStringValues
     public BlockAllocator<ASTNode> astNodeAlloc // Used to allocate all AST nodes
     public UnorderedMap<String, heap SourceFile*> sourceFiles // The GlobalResourceManager owns all source files
-    public Vector<ASTNode*> astNodes
     public CliOptions& cliOptions
     public ExternalLinkerInterface linker
     public CacheManager cacheManager

src-bootstrap/parser/parser.spice

@@ -36,7 +36,6 @@ f<T*> Parser.createNode<T>() {
     // Create the new node
     //T* node = this.resourceManager.astNodeAlloc.allocate(T(this.lexer.getCodeLoc()));
     T* node = this.astNodeAlloc.allocate(T(this.lexer.getCodeLoc()));
-    //this.resourceManager.astNodes.pushBack(node);
 
     // If this is not the entry node, we need to add the new node to its parent
     if !isRootNode {

src/ast/ASTBuilder.cpp

@@ -1354,7 +1354,6 @@ template <typename T> T *ASTBuilder::createNode(const ParserRuleContext *ctx) {
 
   // Create the new node
   T *node = resourceManager.astNodeAlloc.allocate<T>(getCodeLoc(ctx));
-  resourceManager.astNodes.push_back(node);
 
   // If this is not the entry node, we need to add the new node to its parent
   if constexpr (!std::is_same_v<T, EntryNode>)

src/global/GlobalResourceManager.cpp

@@ -35,10 +35,10 @@ GlobalResourceManager::GlobalResourceManager(const CliOptions &cliOptions)
   if (cliOptions.isNativeTarget && cliOptions.useCPUFeatures) {
     // Retrieve native CPU name and the supported CPU features
     cpuName = llvm::sys::getHostCPUName();
-    for (const llvm::StringMapEntry<bool> &feature : llvm::sys::getHostCPUFeatures()) {
+    for (const auto &[name, enabled] : llvm::sys::getHostCPUFeatures()) {
       if (featureString.rdbuf()->in_avail() > 0)
         featureString << ',';
-      featureString << (feature.second ? '+' : '-') << feature.first().str();
+      featureString << (enabled ? '+' : '-') << name.str();
     }
   }
   cpuFeatures = featureString.str();

src/global/GlobalResourceManager.h

@@ -48,7 +48,6 @@ class GlobalResourceManager {
   std::vector<std::string> compileTimeStringValues;
   BlockAllocator<ASTNode> astNodeAlloc = BlockAllocator<ASTNode>(memoryManager); // Used to allocate all AST nodes
   std::unordered_map<std::string, std::unique_ptr<SourceFile>> sourceFiles; // The GlobalResourceManager owns all source files
-  std::vector<ASTNode *> astNodes;
   const CliOptions &cliOptions;
   ExternalLinkerInterface linker;
   CacheManager cacheManager;