🐛 FIx: images labelling for myst images

fixes regression from previous commit
sphinx-extensions2 · Sep 28, 2022 · 033e9f7 · 033e9f7
1 parent c0b4c56
commit 033e9f7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/docs/index.md b/docs/index.md
@@ -276,7 +276,7 @@ Sub-figure with adaptive layouts
 
 ---
 
-:::{subfigure} 2
+:::{subfigure} AB
 :subcaptions: above
 :class-grid: outline
 

diff --git a/src/sphinx_subfigure/main.py b/src/sphinx_subfigure/main.py
@@ -59,10 +59,10 @@ def run(self) -> list[nodes.Element]:
 
         number_of_images = 0
         has_caption = False
-        for idx, child in enumerate(figure_node):
+        for idx, child in enumerate(list(figure_node)):
             if isinstance(child, nodes.image):
+                child["subfigure_area"] = string.ascii_uppercase[number_of_images]
                 number_of_images += 1
-                child["subfigure_area"] = string.ascii_uppercase[idx]
             elif (
                 isinstance(child, nodes.paragraph)
                 and child.children
@@ -72,9 +72,9 @@ def run(self) -> list[nodes.Element]:
                 for sub in child:
                     if not isinstance(sub, nodes.image):
                         continue
-                    number_of_images += 1
                     images.append(sub)
-                    sub["subfigure_area"] = string.ascii_uppercase[idx]
+                    sub["subfigure_area"] = string.ascii_uppercase[number_of_images]
+                    number_of_images += 1
                 child.replace_self(images)
             elif isinstance(child, nodes.paragraph):
                 if has_caption:
@@ -87,6 +87,7 @@ def run(self) -> list[nodes.Element]:
                     f"item {idx + 1} is neither (line {child.line})"
                 )
 
+        print(number_of_images)
         layout_string = self.arguments[0] if self.arguments else 1
         figure_node["layout"] = {}
         figure_node["layout"]["default"] = self.generate_layout(