Fix: no trailing comma in multi-line signatures by default #12975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TLouf Can you fix the conflicts and then request me for review please? |
- C and C++ domains will never feature a trailing comma as it'd correspond to incorrect syntax. - Python and JS get a new config value to optionally disable the trailing comma
TLouf
force-pushed
the
fix-trailing-comma
branch
from
a272868
to
0887051
Compare
|
@picnixz Done, I think this is ready for review. |
TLouf
commented
Oct 19, 2024
| @@ -967,6 +967,133 @@ def test_domain_py_python_maximum_signature_line_length_in_text(app): | |||
| assert expected_parameter_list_foo in content | |||
|
|
|||
|
|
|||
| @pytest.mark.sphinx( | |||
There was a problem hiding this comment.
This is not very elegant, but I don't think there is a way to parametrize a confoverride? If this can somehow be merged in the test above in a smart way, let me know though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: no trailing comma in multi-line signatures by default
Feature or Bugfix
Relates