fix looping mode 3 on very short notes

fixes #52
spessasus · Oct 3, 2024 · 1add6d3 · 1add6d3
1 parent 13c6f49
commit 1add6d3
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 14 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "SpessaSynth",
-  "version": "3.20.36.2",
+  "version": "3.20.36.3",
   "type": "module",
   "scripts": {
     "start": "node src/website/server/server.js"

diff --git a/src/spessasynth_lib/synthetizer/worklet_processor.min.js b/src/spessasynth_lib/synthetizer/worklet_processor.min.js
diff --git a/src/spessasynth_lib/synthetizer/worklet_system/worklet_methods/voice_control.js b/src/spessasynth_lib/synthetizer/worklet_system/worklet_methods/voice_control.js
@@ -40,10 +40,14 @@ export function renderVoice(
         // if not in release, check if the release time is
         if (currentTime >= voice.releaseStartTime)
         {
-
+            // release the voice here
             voice.isInRelease = true;
             WorkletVolumeEnvelope.startRelease(voice);
             WorkletModulationEnvelope.startRelease(voice);
+            if(voice.sample.loopingMode === 3)
+            {
+                voice.sample.isLooping = false;
+            }
         }
     }
 
@@ -264,8 +268,4 @@ export function releaseVoice(voice)
     {
         voice.releaseStartTime = voice.startTime + MIN_NOTE_LENGTH;
     }
-    if(voice.sample.loopingMode === 3)
-    {
-        voice.sample.isLooping = false;
-    }
 }
diff --git a/src/spessasynth_lib/synthetizer/worklet_system/worklet_utilities/lowpass_filter.js b/src/spessasynth_lib/synthetizer/worklet_system/worklet_utilities/lowpass_filter.js
@@ -140,10 +140,7 @@ export class WorkletLowpassFilter
         filter.cutoffHz = absCentsToHz(filter.cutoffCents);
 
         // fix cutoff on low frequencies (fluid_iir_filter.c line 392)
-        if(filter.cutoffHz > 0.45 * sampleRate)
-        {
-            filter.cutoffHz = 0.45 * sampleRate;
-        }
+        filter.cutoffHz = Math.min(filter.cutoffHz, 0.45 * sampleRate);
 
         // adjust the filterQ (fluid_iir_filter.c line 204)
         const qDb = (filter.reasonanceCb / 10) - 3.01;

diff --git a/src/website/js/locale/locale_files/locale_en/export_audio.js b/src/website/js/locale/locale_files/locale_en/export_audio.js
@@ -1,6 +1,6 @@
 export const exportAudio = {
     button: {
-        title: "Save",
+        title: "Save Audio",
         description: "Save the composition to various formats"
     },
 

diff --git a/src/website/minified/demo_main.min.js b/src/website/minified/demo_main.min.js
diff --git a/src/website/minified/local_main.min.js b/src/website/minified/local_main.min.js