-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: geometry objects with new structure #373
feat: geometry objects with new structure #373
Conversation
Thing that came to my mind first: splitting classes to different files will make it behave not like C# (for dev experience), because in Python we cannot assign namespaces. So every import will look slightly redundant: from...object.geometry.point import Point, while in C# it can be just used as Speckle.Geomerty.Point Not necessarily an issue, but an observation |
Re-exporting a module could be an option here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another general observation, currently we do not calculate bbox on the objects. Should we or should we not, up to you or Gergo.
Overall, great work, I hope I helped to find some small blind spots 🙌
This PR splits the geometry objects to different files under geometry/ folder.
Addition to that: