Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dui3 177 receive levels in Revit #3553

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Dui3 177 receive levels in Revit #3553

merged 8 commits into from
Jul 3, 2024

Conversation

connorivy
Copy link
Contributor

Description & motivation

Changes:

RevitRootToHostConverter

  • A mirror of the RevitRootToSpeckleConverter which not only checks for registered conversions of a specific type, but also moves up the inheritance tree when it doesn't find a converter for the specified type

LevelToHostTopLevelConverter

  • Moved over the levelToNative method

LevelConversionToSpeckle

  • This was previously just a 'typedConverter', but I changed this to be a top level converter because not only do we want to converter levels as part of other converters, but we want to send them on their own as well

To-do before merge:

Screenshots:

Validation of changes:

can send and receive levels in Revit

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@connorivy connorivy merged commit 5fddfd9 into dui3/alpha Jul 3, 2024
33 checks passed
@connorivy connorivy deleted the DUI3-177-Levels branch July 3, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants