Add Chinese translation for models - Part II #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Chinese translation for Core Models Signed-off-by: Zhenyu Zheng <[email protected]>
ZhengZhenyu
force-pushed
the
add_chinese_2
branch
from
c02cc1c to
30fc944
Compare
bact
requested changes
Jan 4, 2025
Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: Zhenyu Zheng <[email protected]>
Co-authored-by: Arthit Suriyawongkul <[email protected]> Signed-off-by: Zhenyu Zheng <[email protected]>
bact
requested changes
Jan 5, 2025
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
|
LGTM. The Chinese translation of Part II is highly readable. The logic is clear and the flow between sentences is smooth. The word choices are professional and accurately convey the subtle meanings of the original text. |
|
Thank you for the review @LiuPeng-running . Do you mind to also take a quick look at other Chinese translation PRs here:
Translation:zh-Hans
|
|
A thorough and thoughtful translation. The documents read smoothly in Chinese, and the technical terms are handled appropriately. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Chinese translation for Core Models