Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing software purposes for CDX 1.5 compat #555

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

puerco
Copy link
Collaborator

@puerco puerco commented Nov 14, 2023

This commit adds two new software purposes: deviceDriver and platform to keep the compatibility of this field with the recent CycloneDX 1.5 release.

/cc @kestewart @rnjudge @JPEWdev

Signed-off-by: Adolfo García Veytia (Puerco) [email protected]

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor tweaks requested for conistency.

@@ -27,6 +27,7 @@ about the context in which the Element exists.
- container: the Element is a container image which can be used by a container runtime application
- data: Element is data
- device: the Element refers to a chipset, processor, or electronic board
- deviceDriver: the referred element represents software that controls hardware devices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep standardized with the others? s/the referred element/the Element/ ?

@@ -41,6 +42,7 @@ about the context in which the Element exists.
- operatingSystem: the Element is an operating system
- other: the Element doesn't fit into any of the other categories
- patch: Element contains a set of changes to update, fix, or improve another Element
- platform: The element represents a runtime environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/element/Element/

@puerco puerco force-pushed the missing-compatibility-purposes branch from 3dc6491 to d52cbda Compare November 14, 2023 21:11
@puerco
Copy link
Collaborator Author

puerco commented Nov 14, 2023

@kestewart ok, fixed it to mimic the language in the other lines !

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Aligns with the others now.

This commit adds two new software purposes: `deviceDriver` and `platform` to keep
the compatibility of this field with the recent CycloneDX 1.5 release.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@puerco puerco force-pushed the missing-compatibility-purposes branch from d52cbda to 30e5737 Compare November 15, 2023 00:05
@puerco
Copy link
Collaborator Author

puerco commented Nov 15, 2023

Merge conflicts resolved :shipit:

@rnjudge rnjudge self-requested a review November 15, 2023 00:17
Copy link
Collaborator

@rnjudge rnjudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in the Tech call today. Looks good.

@kestewart kestewart merged commit ef5ca6a into spdx:main Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants