Minor LARK changes (#39)

* Include punct in suffix_id * Lark empty comment * Escaped braces should be strings --------- Co-authored-by: Amanda Tang <[email protected]>
spcl · Oct 1, 2024 · 02ecdf3 · 02ecdf3
1 parent 5dc2b35
commit 02ecdf3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/mlir/dialect.py b/mlir/dialect.py
@@ -79,8 +79,8 @@ def make_rules(cls):
             for fname, ftype in sfields:
                 syntax = syntax.replace('{%s.%s}' % (fname, ftype), ftype)
             # Replace back braces
-            syntax = syntax.replace('{LBRACE}', '{')
-            syntax = syntax.replace('{RBRACE}', '}')
+            syntax = syntax.replace('{LBRACE}', '"{"')
+            syntax = syntax.replace('{RBRACE}', '"}"')
             lark_exprs.append(syntax)
 
         cls._fields_ = list(fields)

diff --git a/mlir/lark/mlir.lark b/mlir/lark/mlir.lark
@@ -27,7 +27,7 @@ constant_literal : bool_literal | integer_literal | float_literal | string_liter
 
 // Identifier syntax
 bare_id : (letter| underscore) (letter|digit|underscore|id_chars)*
-suffix_id : digits | bare_id
+suffix_id : digits | ((letter | id_punct) (letter | id_punct | digits)*)
 
 // Dimensions
 dimension : "?" | decimal_literal
@@ -335,5 +335,5 @@ mlir_file: definition_and_function_list*       -> only_functions_and_definitions
 // Things to ignore: whitespace, single-line comments
 %ignore WS
 
-COMMENT : "//" /(.)+/ NEWLINE
+COMMENT : "//" /(.)*/ NEWLINE
 %ignore COMMENT