[sdk] Support string-based arguments to process resources

spcl · Aug 10, 2023 · 132a6a6 · 132a6a6
1 parent 9f89cc6
commit 132a6a6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/sdk/include/praas/sdk/praas.hpp b/sdk/include/praas/sdk/praas.hpp
@@ -18,7 +18,8 @@ namespace praas::sdk {
     bool create_application(const std::string& application, const std::string& cloud_resource_name);
 
     std::optional<Process> create_process(
-        const std::string& application, const std::string& process_name, int vcpus, int memory
+        const std::string& application, const std::string& process_name, std::string vcpus,
+        std::string memory
     );
 
     ControlPlaneInvocationResult invoke(

diff --git a/sdk/src/praas.cpp b/sdk/src/praas.cpp
@@ -45,14 +45,15 @@ namespace praas::sdk {
   }
 
   std::optional<Process> PraaS::create_process(
-      const std::string& application, const std::string& process_name, int vcpus, int memory
+      const std::string& application, const std::string& process_name, std::string vcpus,
+      std::string memory
   )
   {
     auto req = drogon::HttpRequest::newHttpRequest();
     req->setMethod(drogon::Put);
     req->setPath(fmt::format("/apps/{}/processes/{}", application, process_name));
-    req->setParameter("vcpus", std::to_string(vcpus));
-    req->setParameter("memory", std::to_string(memory));
+    req->setParameter("vcpus", vcpus);
+    req->setParameter("memory", memory);
 
     std::promise<std::optional<Process>> p;
 
@@ -65,6 +66,7 @@ namespace praas::sdk {
             auto port = json_obj["connection"]["port"].asInt();
             p.set_value(Process{ip_addr, port, true});
           } else {
+            std::cerr << *response->getJsonObject() << std::endl;
             p.set_value(std::nullopt);
           }
         }