Add CFG to generate_scope in tutorials #1706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I saved it also trimmed some trailing whitespace (lines that only have whitespace, it is for the better I think) |
tbennun
requested changes
Oct 24, 2024
| " # an SDFG has a scope with that schedule\n", | ||
| " def generate_scope(self, sdfg: dace.SDFG, scope: ScopeSubgraphView,\n", | ||
| " def generate_scope(self, sdfg: dace.SDFG, dfg, scope: ScopeSubgraphView,\n", | ||
| " state_id: int, function_stream: CodeIOStream,\n", | ||
| " callsite_stream: CodeIOStream):\n", | ||
| " # The parameters here are:\n", | ||
| " # sdfg: The SDFG we are currently generating.\n", | ||
| " # scope: The subgraph of the state containing only the scope (map contents)\n", |
There was a problem hiding this comment.
add tutorial documentation
phschaad
requested changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DFG is missing from codegen tutorial, resulting with an error in codegen. Adding cfg as a param fixes it.