Move placeholder generation into job #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you send a PR that updates the command as well? |
|
I don't think I understand what you're asking? The placeholder job is already dispatched in the command with |
|
Ah sorry! Read the code on mobile and missed that bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #253, this PR moves the placeholder generation into a job than can be dispatched when using the
php please responsive:generatecommand.I've tested it with both glide caching on and off. The arbitrary
cacheparameter is still needed to not break the placeholder when switching between cache on/off.BTW, this is for the same site that @jackmcdade mentioned in the recent discussion.