Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP 8.4 deprecation #26

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Fix PHP 8.4 deprecation #26

merged 2 commits into from
Dec 16, 2024

Conversation

LordSimal
Copy link
Contributor

Resolves #25

@freekmurze freekmurze merged commit e2b39ba into spatie:main Dec 16, 2024
15 checks passed
@freekmurze
Copy link
Member

Thanks!

@LordSimal
Copy link
Contributor Author

I just checked your CI and there seem to be more warnings. Another PR is incoming 😉

@LordSimal
Copy link
Contributor Author

Ah no, those are deprecations in other spatie packages 😅
At least this package should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.4 deprecation: Implicitly marking parameter $sort as nullable is deprecated
2 participants
@LordSimal @freekmurze