Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spatie/laravel-backup ^9.x compatibility fix #146

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

makowskid
Copy link
Contributor

I think you guys have forgotten about this little thingie :)

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit f96660d into spatie:main Oct 14, 2024
0 of 6 checks passed
@kichetof
Copy link

Hello,

v9 is a breaking change for Nova Backup Tool as createForMonitorConfig signature change from v8 to v9:

// v8
    public static function createForMonitorConfig(array $monitorConfiguration): Collection

// v9
    public static function createForMonitorConfig(MonitoredBackupsConfig $monitorConfiguration): Collection

And Nova Backup Tool instantiate createForMonitorConfig with an array, instead of MonitoredBackupsConfig::fromArray($data['monitor_backups'])

What do you think?

Thanks!

@kichetof
Copy link

PR sent #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants