Adds support for getting progress on individual steps #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance we can get this PR reviewed? Thanks! |
freekmurze
requested changes
Jan 26, 2024
| $this->getProgress(); | ||
| } | ||
|
|
||
| public function getProgress(): float |
There was a problem hiding this comment.
Instead of calculating the percentage of the progress, I would just let the component be aware of the stepnumber and total number of steps.
Formatting this info as a percentage is then a task for the user of the package, and not the package itself.
|
Closing as it can be done outside the package inside the Form component. Thanks for the help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR adds a new property to the step classes that allows a user to determine the progress through the wizard. The property is set during the boot up procedure of the StepAware trait. I've added tests to the current suite as well.
I am looking for suggestions if this is the best place to put the logic - or should it be in the base Step component class? Also, should we add a method on the form class to determine progress overall using the currentStepName property? Thanks for the feedback!