fix: do not try to send notifications when they are disabled #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the command will be triggered from the /health endpoint and will send a notification no matter what is configured. This PR adds a check so that it will only do that when notifications are actually enabled.
kolaente
commented
Jul 3, 2024
| @@ -29,7 +29,7 @@ public function handle(): int | |||
|
|
|||
| $results = $this->runChecks(); | |||
|
|
|||
| if (! $this->option('no-notification')) { | |||
| if (! $this->option('no-notification') && config('health.notifications.enabled', false)) { | |||
There was a problem hiding this comment.
I'm not sure if this is the right place for this, but it fixes the problem for me.
|
The test failure seems to be related to a change in space for a function, do the fixtures need adjustement? |
|
Could you rebase against |
|
Done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the command will be triggered from the /health endpoint and will send a notification no matter what is configured. This PR adds a check so that it will only do that when notifications are actually enabled.
In an application I'm building, we don't have mails configured. Because of that, sending the notification fails later on and spams the log with failed attempts, making tracking actual errors way harder.