V3 #199
Merged
V3 #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great news! Any chance you can downgrade the minimum PHP requirement to 8.1? Tests seem to run fine for that version too. |
* init phpstan * fix first set of issues * add todo for missing use case * explicitly transform floats to int * imagepng() expects quality param to be an integer between 0 and 9 * method returns float, variable where stored is also typed as float * define array structures * add more array type hints * change interface params to match the actual implementations * Fix styling * add phpstan workflow * change missing types to int|float * Fix styling * move exif stuff to baseline * replace intval() with (int) (int) is consider the best practice as it is up to 6x faster * Fix styling * int/float fixes * Fix styling --------- Co-authored-by: Nielsvanpach <[email protected]>
* remove positive_int annotations will fail on a 0 value * alpha values can be floats * increase phpstan level + fixes * Fix styling * exclude relevant phpstan issues from baseline --------- Co-authored-by: Nielsvanpach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR for the new v3 release of the Image package.
Goal: be less reliant on dependencies while retaining the powerfull API the package already provides.
Still to implement:
image/tests/Manipulations/FitTest.php
Line 92 in 2fe5e2d
To document:
Not needed anymore