-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add BaseRobyn class #1100
add BaseRobyn class #1100
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #1100 will not alter performanceComparing Summary
|
@sansyrox two questions about this
Thanks |
6ee78c5
to
0f16260
Compare
Hey @dave42w 👋 Thanks for the PR 😄
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dave42w 👋
Overall, this is a great start point for the refactor. Looks good to me!! ❇️
we probably also don't need a file_path in the subrouters now, right? |
Yup the init was going to be the next step. |
07f28de
to
0b766c9
Compare
Good job and thanks @dave42w ! |
Description
This PR refactors Robyn and SubRouter by adding an abstract BaseRobyn that is a common superclass.
So far the only method in Robyn itself (and therefore not in SubRouter) is start.
PR Checklist
Please ensure that:
Pre-Commit Instructions: