Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add BaseRobyn class #1100

Merged
merged 2 commits into from
Jan 7, 2025
Merged

add BaseRobyn class #1100

merged 2 commits into from
Jan 7, 2025

Conversation

dave42w
Copy link
Contributor

@dave42w dave42w commented Dec 31, 2024

Description

This PR refactors Robyn and SubRouter by adding an abstract BaseRobyn that is a common superclass.

So far the only method in Robyn itself (and therefore not in SubRouter) is start.

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 31, 2024 7:59am

Copy link

codspeed-hq bot commented Dec 31, 2024

CodSpeed Performance Report

Merging #1100 will not alter performance

Comparing dave42w:BaseRobyn (6b3f6bd) with main (2aad774)

Summary

✅ 138 untouched benchmarks

@dave42w
Copy link
Contributor Author

dave42w commented Jan 2, 2025

@sansyrox two questions about this

  1. Are you happier about keeping all this in init.py or do you want me to move BaseRobyn into baserobyn.py?
  2. Which other methods do you think are ready to move out of BaseRobyn into Robyn (ie that SubRouter should not use).

Thanks

@sansyrox sansyrox force-pushed the main branch 3 times, most recently from 6ee78c5 to 0f16260 Compare January 2, 2025 21:41
@sansyrox
Copy link
Member

sansyrox commented Jan 3, 2025

Hey @dave42w 👋

Thanks for the PR 😄

  1. Let's keep everything in __init__.py for now.
  2. Let me do a complete review and get back 😄

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dave42w 👋

Overall, this is a great start point for the refactor. Looks good to me!! ❇️

@sansyrox
Copy link
Member

sansyrox commented Jan 4, 2025

we probably also don't need a file_path in the subrouters now, right?

@dave42w
Copy link
Contributor Author

dave42w commented Jan 5, 2025

we probably also don't need a file_path in the subrouters now, right?

Yup the init was going to be the next step.

@sansyrox sansyrox force-pushed the main branch 2 times, most recently from 07f28de to 0b766c9 Compare January 7, 2025 01:44
@sansyrox
Copy link
Member

sansyrox commented Jan 7, 2025

Good job and thanks @dave42w !

@sansyrox sansyrox merged commit 46d6521 into sparckles:main Jan 7, 2025
50 checks passed
@dave42w dave42w deleted the BaseRobyn branch January 10, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants