Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing function return types (mostly None) to reloader.py #1058

Merged
merged 4 commits into from
Nov 30, 2024

Conversation

dave42w
Copy link
Contributor

@dave42w dave42w commented Nov 26, 2024

Description

This PR improves type hinting by adding return type hints to the functions in reloader.py that didn't have them.

PR Checklist

Please ensure that:

  • [X ] The PR contains a descriptive title
  • [X ] The PR contains a descriptive summary of the changes
  • [X ] You build and test your changes before submitting a PR.
  • [X ] You have added relevant documentation
  • [X ] You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 9:30am

robyn/reloader.py Outdated Show resolved Hide resolved
@dave42w
Copy link
Contributor Author

dave42w commented Nov 29, 2024

Hi @sansyrox
I'm getting lots of false ci failures at the moment (mostly timeouts). Is that upgrade to uv going to fix these?

robyn/reloader.py Outdated Show resolved Hide resolved
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dave42w 👋

Thank you for the PR, just have one suggestion

Copy link

codspeed-hq bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #1058 will not alter performance

Comparing dave42w:reloader.py (b3f56cb) with main (7fe0c04)

Summary

✅ 146 untouched benchmarks

@dave42w
Copy link
Contributor Author

dave42w commented Nov 30, 2024

Hey @dave42w 👋

Thank you for the PR, just have one suggestion

Sorry about that.

I'm getting so many ci errors that it's hard to spot the real ones.
Also a worry that some real errors only show up on only one platform when it should be consistent.
Anyway this is now showing the rust warning.
https://github.com/sparckles/Robyn/actions/runs/12095320152/job/33728364712#step:4:1

@sansyrox
Copy link
Member

I'm getting so many ci errors that it's hard to spot the real ones.
Also a worry that some real errors only show up on only one platform when it should be consistent.
Anyway this is now showing the rust warning.

Thanks for raising this. Need to address this!

@sansyrox sansyrox merged commit d900cab into sparckles:main Nov 30, 2024
59 of 60 checks passed
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@dave42w dave42w deleted the reloader.py branch November 30, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants