-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing function return types (mostly None) to reloader.py #1058
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @sansyrox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dave42w 👋
Thank you for the PR, just have one suggestion
CodSpeed Performance ReportMerging #1058 will not alter performanceComparing Summary
|
Sorry about that. I'm getting so many ci errors that it's hard to spot the real ones. |
Thanks for raising this. Need to address this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Description
This PR improves type hinting by adding return type hints to the functions in reloader.py that didn't have them.
PR Checklist
Please ensure that:
Pre-Commit Instructions: