Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant else statement in ws.py #1052

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Conversation

dave42w
Copy link
Contributor

@dave42w dave42w commented Nov 25, 2024

Description

This PR refactors to cut a redundant else (the code below the raise exception does not need protecting by the else

Summary

This PR removes an else and unindents the 3 lines of code

PR Checklist

Please ensure that:

  • [X ] The PR contains a descriptive title
  • [X ] The PR contains a descriptive summary of the changes
  • [X ] You build and test your changes before submitting a PR.
  • [X ] You have added relevant documentation
  • [X ] You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 3:47pm

Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #1052 will not alter performance

Comparing dave42w:ws.py (dedd3b9) with main (7fe0c04)

Summary

✅ 146 untouched benchmarks

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄

@sansyrox sansyrox merged commit d178f1c into sparckles:main Nov 30, 2024
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants