Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data file locations for build 11 #26

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

sosey
Copy link
Member

@sosey sosey commented Feb 1, 2024

Script is updated to point to the data for build 11

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the notebooks run!

@sosey
Copy link
Member Author

sosey commented Feb 1, 2024

@zacharyburnett dont quite merge yet....

@nden
Copy link
Collaborator

nden commented Feb 2, 2024

We need to send files that match Build12.
A Level 2 imaging file matching the Build 12 release is in ExampleData. A grism Level 2 file matching Build 12 is in ExampleData/grsim_data (may have the name wrong).

Recently there was interest only in getting the Level 2 files so when I uploaded them I did not upload a L1 file and did not update the notebooks. If this is needed, a L1 file needs to be uploaded to Box and the notebooks updated. Perhaps @WilliamJamieson can help with this.

@sosey
Copy link
Member Author

sosey commented Feb 2, 2024

@ddavis-stsci generated new files for me. It took a while to upload, but I tested the download successfully. When the tests pass here we should be good to merge @zacharyburnett

@zacharyburnett zacharyburnett merged commit 4ac5b8d into spacetelescope:main Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants