Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show atxs count #1685

Merged
merged 10 commits into from
Mar 14, 2024
Merged

Show atxs count #1685

merged 10 commits into from
Mar 14, 2024

Conversation

brusherru
Copy link
Member

It includes:

  • Refactored how API is integrated and generated: now API is a submodule, and it is possible to use v1 and v2alpha1 at the same time
  • Display amount of synced ATXs on the Network screen, when it is syncing activations:
    Screen.Recording.2024-03-01.at.23.43.28.mov

Prerequisite:

It is based on #1684

How to test:

Build go-spacemesh from develop and put it into node/{mac|windows|linux} and then run Smapp yarn && yarn start

@brusherru brusherru self-assigned this Mar 1, 2024
pigmej
pigmej reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@pigmej pigmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we show "per epoch' ? The cumulative number looks "weird" but maybe it's my personal feeling.

@brusherru
Copy link
Member Author

The cumulative number looks "weird" but maybe it's my personal feeling.

E.g. Syncing activations for epoch 12 (32123)...? 🤔

@pigmej
Copy link
Member

pigmej commented Mar 1, 2024

The cumulative number looks "weird" but maybe it's my personal feeling.

E.g. Syncing activations for epoch 12 (32123)...? 🤔

Something like that :) not 100% but looks easier to track imo and makes the user to see the epochs etc.

@brusherru
Copy link
Member Author

brusherru commented Mar 5, 2024 •
edited
Loading

It depends on spacemeshos/go-spacemesh#5645 (build go-sm from this branch for tests)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Compiled Binaries

monikasmolarek
monikasmolarek reviewed Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@monikasmolarek monikasmolarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to build locally the go-sm from the PR you mentioned, as well as the develop branch (when pr was already merged) but even though smapp starts, the node underneath doesn’t want to start (on both Mac and Win). I don’t have the logs to attach cause the node never started. I tried to run the same go-sm build without smapp and it runs normally. In general I had no problem building smapp earlier with locally built go-sm while testing other PRs even earlier this week.

Just as a reminder, go-sm v1.4.0-alpha.1 which was experimental and is quite old now had some issues with database and the node didn’t want to run. But the 15alpha3-nomain was fine.

Is there anything I could or should do to debug it?

@pigmej pigmej self-requested a review March 12, 2024 14:24
pigmej
pigmej previously approved these changes Mar 12, 2024
View reviewed changes
Base automatically changed from chore-support-1.4.0 to develop March 14, 2024 07:19
@brusherru brusherru dismissed pigmej’s stale review March 14, 2024 07:19

The base branch was changed.

@github-actions GitHub Actions
Copy link

Compiled Binaries

@brusherru brusherru merged commit 8c17dad into develop Mar 14, 2024
8 checks passed
@brusherru brusherru deleted the feat-show-atxs-count branch March 14, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monikasmolarek monikasmolarek monikasmolarek left review comments

@pigmej pigmej pigmej left review comments

Assignees

@brusherru brusherru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brusherru @pigmej @monikasmolarek