Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't restart node every hour #1362

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Conversation

brusherru
Copy link
Member

No issue on GH.

BUG

Smapp restarts the Node every hour when checking for the Node config update.

How to test

  1. Serve your custom discovery (networks.json and config.json)
  2. Run Smapp with arguments:
    • --check-interval=60 argument (or CHECK_INTERVAL=60 env var) to check for updates every 60 seconds
    • --discovery=http://localhost:8000/networks.json (or same as DISCOVERY_URL=...)
  3. Wait a couple of minutes to ensure it is not restarting the Node
  4. Change the config served in your custom discovery (you can add any property into json, just keep it valid and keep valid props)
  5. Wait for one minute more — your Node will restart and Smapp should continue working
  6. Wait for a couple more minutes to ensure it is not restarting the Node

You should be able to reproduce it on v1.0.3 on any network, just change --check-interval to any small amount, because it is one hour by default.

@brusherru brusherru self-assigned this Jul 14, 2023
@maparr maparr added the bug Something isn't working label Jul 14, 2023
@github-actions
Copy link

Compiled Binaries

@brusherru brusherru merged commit 7733e23 into develop Jul 14, 2023
8 checks passed
@brusherru brusherru deleted the fix-dont-restart-node-hourly branch July 14, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants