Fix: calculate genesis id properly

[brusherru]

It closes #1377

[dshulyak]

is there an option to render it after fetching from grpc? it obviously won't change at this point, but in general it would be more robust to trust the local node on this info

[dshulyak]

parseISODate returns milliseconds?

[brusherru]

Yeah

Agree about fetching from grpc, but we're indexing networks by genesis id (auto-connect to them, store logs using it and etc) — so we need it earlier (and even if Node does not work).

But probably Smapp should show some alerts in case the calculated genesis id and the one returned from API are different.

[github-actions]

Compiled Binaries

• Windows: x64
• macOS: x64 arm64
• Linux
  • AppImage x64 arm64
  • deb x64 arm64

[brusherru]

Okay, I just realized that if we will merge and deploy it as is — we will break UX for all Users.
Because Smapp will search for another network, another config file, etc.
We need some more code that will smoothly migrate to the new genesis id.
Like,

const oldGenesisId = legacyFalsyGenesisId(nodeConfig);
if (oldGenesisId === wallet.meta.genesisID) {
  const newGenesisId = genGenesisId(nodeConfig);
  updateWallet({ ..., genesisId: newGenesisId });
  saveCustomNodeConfig(newGenesisId, loadCustomNodeConfig(oldGenesisId));
}

[brusherru]

It is ready for review.
Please, check it out carefully, because it's a supercritical change! 🙏

How it works:

• when the User opens a wallet pointing to the network using old-wrong genesis id, it will...
• "migrate" custom node config and node data dir, but keep PoS data as is
• it also adds one line in the spacemesh-log just to reference previous logs
• update the wallet file and change the genesis id to the new one
• shows Wallet screen as usually

In case you are unlocking such a wallet, while you already have node-config.NEW_ID.json or node-data/NEW_ID — then it won't rename anything and just switch the wallet on proper genesis id.

--
P.S.
The easiest way to test it well — is to back up your Spacemesh/Electron directory every time before unlocking, because Smapp will rename some files there :)

[github-actions]

Compiled Binaries

• Windows: x64
• macOS: x64 arm64
• Linux
  • AppImage x64 arm64
  • deb x64 arm64

[monikasmolarek]

Tested on macOS only:

• Wallet files and wallet screen ok,
• Logs files ok,
• POS location and generation ok
• node-config.GENESIS_ID.json migrated except the "smeshing-proving-opts" (the same behaviour after each pause/restart pos, even on latest release, without switching to any other versions)

Switching between smapp versions, pausing and resuming POS generation caused (the same on pure latest release with no version changing):

[brusherru]

@monikasmolarek This is another issue, reproducible in develop and does not related to genesis id.
So we will need to fix it in a separate PR.

[maparr]

LGTM