fix: use genesisID in custom config name #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maparr
force-pushed
the
fix/custom-config-use-genesisID
branch
from
d6b4877
to
399305f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue related to the TEST MODE for go-sm.
The name for custom config file should not match to the same name but a different config. Genesis ID will be unique and testnet-5 and testnet-5 with different GenesisID will create a different custom config file which the client can update
as result, resolving test mode for go-sm, feature wich we're using all the time for development process
expected result:
on creating a custom config, don't use name, but use genesisID.