Use setWindowOpenHandler() in favor of deprecated new-window event
#1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cl8n , thank you for the contribution! |
|
Hi @cl8n , we didn't use electron 22 for now, may u describe where did u face this warning? |
|
When clicking a purple button in smapp that opens a Browser window. |
brusherru
approved these changes
Jul 19, 2023
|
@cl8n thanks for the contribution! ❤️ |
|
woops sorry for not responding there, thanks for the screenshot. that was indeed where I noticed the warning 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed a warning for this one in stderr. the event is removed in electron 22