Allow customisation of node config #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maparr
force-pushed
the
feat/1019
branch
2 times, most recently
from
9d5a26a
to
07ea86e
Compare
|
I can't really do anything because: |
|
@monikasmolarek , got it ,on it |
maparr
force-pushed
the
feat/1019
branch
2 times, most recently
from
37a4a36
to
da5355a
Compare
|
Tested only on Windows this time:
|
|
|
monikasmolarek
previously approved these changes
Jun 13, 2023
maparr
commented
Jul 3, 2023
| @@ -3,6 +3,6 @@ module.exports = { | |||
| preset: 'ts-jest', | |||
| runner: '@jest-runner/electron/main', | |||
| testEnvironment: 'node', | |||
| testRegex: '(/tests/.*|(\\.|/)(test|spec))\\.ts$', | |||
| testMatch: ['**/?(*.)+(spec|test).ts'], | |||
There was a problem hiding this comment.
update, to be able to run tests locally for a file or just 1 test
There was a problem hiding this comment.
yarn test ./tests/some.spec.ts was working well previously, but this seems working too :)
There was a problem hiding this comment.
jest nodeConfig - will run 1 file
jest -t 'name of the test' will run only 1 specific test
to simplify the test creation process.
maparr
force-pushed
the
feat/1019
branch
2 times, most recently
from
59f00ff
to
e1eb10d
Compare
|
Scenario 5 - Switching the Network with POS setup previously : After manual app restart it seems to be ok. The most important thing - the config behaved correctly even though Smapp wasnt reflecting before the app restart. One big issue is restrting the node after changng the network - it doesn't want to restart itself, the "Restart" button on the network screen doesnt help- it tries but falls again and shows again the "restart" button. Only manual restart helps. I will try to verify it again and create an issue for that. In general, all te scenarios are ok👌 (tested on Windows 10). If the above error modal isn't related/big blocker, then I would approve as well. |
|
Ok, I checked with the latest release exactly the same steps- after switching the network, the node got up with just 1 click on the "restart node" button on the Network screen. |
|
All the previously mentioned aspects are resolved, however now after the second switch - back to the first network&POS, my smesher screen froze for some time like this - half of the info not updated - directory from testnet-05, 40MiB of pos size from devnet-401. |
|
Also, after the network switch, the "Started creating POS data" timestamp on the right remained. It's a topic for a separate issue, itsn't it? |
❗ Sounds pretty critical. After switching the network User should not click any "Restart" buttons.
Yeah... go-spacemesh and his API a bit hanging because of the big batch size on a slow GPU :(
@monikasmolarek please open an issue for it 🙏 p.s. @maparr please in case of any further changes — push separate commits to make it easier to review. |
|
all resolved. only this restart network cannot reproduce will be testing on Windows Cloud PC |
|
Hi @monikasmolarek , did the check on Windows, ( virtual ) , with not the best configuration. As result, yes, I'm getting this issue, but the main point on restart, need to wait for a long time 1 minute at least, for the not-best PC, till the node will start again. My configuration has only a CPU. But for both tries, the node is starting after switching networks. For Mac m1 max, it is taking 10 secs ( or even 1 ), for CPU Intel or what we have for the cloud, it takes longer. I think we need to create and issue for this case ( for Windows or PC with not perfect configuration) and create maybe some fix after the discussion, like, please wait for, and not show your node is down if it is running. But it definitely not an issue with this PR also, I think, because of tons of logs, #1283 is related not only macOS , but to Windows first. issue with timestamps resolved and will be available for review when this PR will be merged - #1326 cc: @brusherru |
maparr
commented
Jul 10, 2023
| @@ -459,7 +459,7 @@ const Node = ({ history, location }: Props) => { | |||
| <Address | |||
| key="smesherCoinbase" | |||
| type={AddressType.ACCOUNT} | |||
| address={coinbase} | |||
| address={coinbase || ''} | |||
There was a problem hiding this comment.
because of a fast new flow , we're supporting smeshing from different folders from different configs ( right now each network may have its own smeshing options) , during node restart we're updating and smeshing process and till we're waiting for updates from the node, for 1 ms , we can get new update from the node where the coinbase not updated yet. It is just an issue with the update and react renderer. The user won't see an empty address
There was a problem hiding this comment.
seems after https://github.com/spacemeshos/smapp/pull/1334/files#diff-2f272b881ae8ff902e02cbd366f81c899b63396572563819304c10f4ebd5e769R547 merge It, my changes not needed. At least will be rewritten.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It closes #1019
Additionally: resolving an issue with stale genesisID for managers, because of spawn managers, currently in develop, we're passing the genesisID only once and after it, reuse the genesisID and only change it on the wallet change or app restart.
UPD How to test
2 case
1 . set up smeshing
6 . switch back to the first network and compare.
Screen.Recording.2023-06-22.at.09.49.10.mov