Skip to content

Commit

Permalink
Merge pull request #1681 from spacemeshos/remove_sentry
Browse files Browse the repository at this point in the history
Remove sentry
  • Loading branch information
monikasmolarek authored Mar 5, 2024
2 parents c8f6f53 + a15a2db commit 88f4eb3
Show file tree
Hide file tree
Showing 23 changed files with 68 additions and 841 deletions.
13 changes: 0 additions & 13 deletions .github/workflows/pr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,6 @@ jobs:
# Build
- name: yarn build
run: yarn build
env:
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_ENV: pr-builds

# Create binaries
- if: matrix.platform == 'linux'
Expand All @@ -195,28 +191,19 @@ jobs:
echo "USE_SYSTEM_FPM?$(echo $USE_SYSTEM_FPM)"
yarn package-linux
env:
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_ENV: pr-builds
USE_SYSTEM_FPM: ${{ matrix.id == 'linux-arm64' && 'true' }}

- if: matrix.platform == 'windows'
name: Build windows app
run: yarn package-win
env:
DONT_SIGN_APP: true # Do not sign the development artifacts
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_ENV: pr-builds

- if: matrix.platform == 'macos'
name: Build mac app
run: yarn package-mac
env:
DONT_SIGN_APP: true # Do not sign the development artifacts
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_ENV: pr-builds

- name: ls ./release
run: ls ${{matrix.platform != 'windows' && '-la' || ''}} ./release
Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -187,31 +187,20 @@ jobs:

- name: Build
run: yarn build
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}

# Create binaries
- if: matrix.platform == 'linux'
name: Build linux app
run: yarn package-linux
env:
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
USE_SYSTEM_FPM: ${{ matrix.id == 'linux-arm64' && 'true' }}
- if: matrix.platform == 'windows'
name: Build windows app
run: yarn package-win
env:
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
- if: matrix.platform == 'macos'
name: Build mac app
run: yarn package-mac
env:
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
CSC_LINK: ${{ secrets.SIGNING_CERTIFICATE_P12_DATA }}
CSC_KEY_PASSWORD: ${{ secrets.SIGNING_CERTIFICATE_PASSWORD }}
APPLEID: ${{ secrets.APPLE_ID }}
Expand Down
10 changes: 1 addition & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,7 @@ PPROF_SERVER=1 yarn start

Alias for `--pprof-server` argument.

#### Sentry

```
SENTRY_DSN='collection errors/logs url taken from sentry'
SENTRY_LOG_LEVEL=boolean # enables debug information
SENTRY_AUTH_TOKEN='special auth token for sentry cli integration'
```

### Building Artifacts in CI
#### Building Artifacts in CI

Smapp uses two workflows. Both of them build an application for all supported platforms: Windows, macOS, and Linux.

Expand Down
3 changes: 0 additions & 3 deletions app/ErrorBoundary.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import React, { Component } from 'react';
import styled from 'styled-components';
import { captureException } from '@sentry/react';
import { connect } from 'react-redux';
import { Modal } from './components/common';
import { Button } from './basicComponents';
Expand Down Expand Up @@ -82,8 +81,6 @@ class ErrorBoundary extends Component<Props, State> {
{ componentStack }: { componentStack: string }
) {
console.log(`${error.message} ${componentStack}`); // eslint-disable-line no-console
captureException(error);

const { setUiError } = this.props;
const failedComponentMatch = componentStack
.split('\n')
Expand Down
3 changes: 0 additions & 3 deletions app/StyledApp.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,10 @@ import ErrorBoundary from './ErrorBoundary';
import { ipcConsts } from './vars';
import { goToSwitchAPI, goToSwitchNetwork } from './routeUtils';
import { getThemeById } from './theme';
import { init } from './sentry';
import Modals from './Modals';

const history = createMemoryHistory();

init(history);

const EventRouter = () => {
const onSwitchNet = (_, { isWalletOnly }) =>
goToSwitchNetwork(history, isWalletOnly);
Expand Down
1 change: 1 addition & 0 deletions app/basicComponents/Link.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const Wrapper = styled.div<{
line-height: 17px;
font-weight: ${({ isPrimary }) => (isPrimary ? 400 : 800)};
text-decoration: underline;
text-underline-offset: 3px;
${({ isDisabled, isPrimary }) =>
isDisabled
? `color: ${smColors.disabledGray};`
Expand Down
Loading

0 comments on commit 88f4eb3

Please sign in to comment.