Skip to content

Fix download

Fix download #56

Triggered via pull request June 24, 2024 15:14
@brusherrubrusherru
synchronize #13
fix-download
Status Failure
Total duration 56s
Artifacts

ci.yml

on: pull_request
Matrix: Build library
Publish release
0s
Publish release
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
Rustfmt
Process completed with exit code 1.
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
this expression creates a reference which is immediately dereferenced by the compiler: src/main.rs#L147
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/main.rs:147:38 | 147 | let go_version = get_version(&go_path_str)?; | ^^^^^^^^^^^^ help: change this to: `go_path_str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
unneeded `return` statement: src/main.rs#L132
warning: unneeded `return` statement --> src/main.rs:132:13 | 132 | return Ok::<i32, anyhow::Error>(0); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 132 - return Ok::<i32, anyhow::Error>(0); 132 + Ok::<i32, anyhow::Error>(0) |
this expression creates a reference which is immediately dereferenced by the compiler: src/main.rs#L99
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/main.rs:99:23 | 99 | match backup_file(&file_path) { | ^^^^^^^^^^ help: change this to: `file_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/utils.rs#L84
warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/utils.rs:84:23 | 84 | let url = build_url(&download_url, &path); | ^^^^^^^^^^^^^ help: change this to: `download_url` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default
file opened with `create`, but `truncate` behavior not defined: src/download.rs#L19
warning: file opened with `create`, but `truncate` behavior not defined --> src/download.rs:19:6 | 19 | .create(true) | ^^^^^^^^^^^^- help: add: `.truncate(true)` | = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` = help: alternatively, use `.append(true)` to append to the file instead of overwriting it = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options = note: `#[warn(clippy::suspicious_open_options)]` on by default
unneeded unit return type: src/main.rs#L93
warning: unneeded unit return type --> src/main.rs:93:39 | 93 | fn backup_or_fail(file_path: &PathBuf) -> () { | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default
clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/